-
Notifications
You must be signed in to change notification settings - Fork 7
Adds Python bindings to Adiak #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Edit: Tested for multi-rank with communicator and different types. |
daboehme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice work! Would be great to get an example, a test case, and documentation before we merge it in.
|
Also, I think it would be good to make MPI an optional dependency for the Python interface as well. |
|
@daboehme Added docs. I was thinking of updating this example https://software.llnl.gov/Caliper/PythonSupport.html#caliper-python-api to add Adiak and then reference that as an example. Thoughts? |
I think it would be good to have a chapter in the Adiak docs for the Python API with a small Caliper-free example specifically for Adiak. We can eventually add a combined Adiak/Caliper example too that can go into the Caliper documentation or tutorial. That's out of the scope for this PR though. |
|
Ok added a test, and documentation (+ example). @daboehme Can we try running the workflow again? |
Follow up to Slack discussions with @michaelmckinsey1.
This PR adds Python bindings to Adiak, similar to those added to Caliper.
Like Caliper, these bindings consist of 2 parts:
Also similar to Caliper, these bindings are installed to
lib[64]/pythonX.Y/site-packages/pyadiak(where "X.Y" refers to the Python version used during build).